This repository was archived by the owner on May 14, 2020. It is now read-only.
added JSONDateNode to display Date values #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
examples/src/App.js
Outdated
Contributor
There was a problem hiding this comment.
Date() returns a string object, not a date object. I'd use `new Date() instead.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date
Closed
src/grab-node.js
Outdated
Contributor
There was a problem hiding this comment.
You need to import JSONDateNode at the top of this file, and use JSONDateNode instead of JSONNullNode.
Contributor
Author
|
ah, I did try to place the ISO method there but I guess it didn't work because of my other errors! making changes now.. |
chibicode
added a commit
that referenced
this pull request
Sep 10, 2015
added JSONDateNode to display Date values
Contributor
|
@liamkennedy89 thanks! merged. |
Contributor
Author
|
@chibicode excellent. thanks for your patience |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
couldn't figure out how to call .toISOString()...
closes #4